[SPARK-8810] [SQL] Added several UDF unit tests for Spark SQL #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| testData.sqlContext.udf.register("havingFilter", (n:Long) => { n > 5 }) | ||
|
|
||
| val result = | ||
| testData.sqlContext.sql("SELECT g, SUM(v) as s FROM groupData GROUP BY g HAVING havingFilter(s)") |
There was a problem hiding this comment.
we now prefer just having the dataset closer to the test case rather than putting them in TestData.
You can do something like this easily in each test case itself
val df = Seq(("red", 1), ("red", 2), ("blue", 10), ("green", 100), ("green", 200)).toDF("g", "v")
df.registerTempTable("groupData")
There was a problem hiding this comment.
This line exceeds 100 characters and the last test failure is due to this. @spirom , Could you add proper indentation here?
|
Thanks - looks pretty good for the first patch! There are just some minor style issues. |
|
Jenkins, ok to test. |
|
ok to test. |
|
Test build #36484 has finished for PR 7207 at commit
|
|
Test build #36512 has finished for PR 7207 at commit
|
|
Thanks - I've merged this in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test for each of the GROUP BY, WHERE and HAVING clauses, and one that combines all three with an additional UDF in the SELECT.
(Since this is my first attempt at contributing to SPARK, meta-level guidance on anything I've screwed up would be greatly appreciated, whether important or minor.)